D27728: Multiple dataset to chronos

[Johnny Jazeix]

jjazeix added a comment.


  Except those small changes, looks good to me.
  @echarruau, @timotheegiet any comment to add?

INLINE COMMENTS

> Babymatch.qml:94
>              id: bar
> -            content: BarEnumContent { value: help | home | level }
> +            content: BarEnumContent { value: useMultipleDataset ? help | home | level | activityConfig : help | home | level }
>              onHelpClicked: {displayDialog(dialogHelp)}

use parenthesis to separate the different values

> babymatch.js:79
> +    if(useMultipleDataset)
> +        var filename = items.levels[currentLevel-1][currentSubLevel];
> +    else

you can directly set items.dataset.source here and below

> babymatch.js:84
>      var levelData = items.dataset.item
> -    
> -    items.availablePieces.model.clear()
> -    for(var i = 0 ; i < spots.length ; ++ i) 
> -        spots[i].destroy()
> -    spots = []
> -    
> -    for(var i = 0 ; i < showText.length ; ++ i) 
> -        showText[i].destroy()
> -    showText = []
> -    
> -    items.backgroundPiecesModel.clear()
> -    items.backgroundImage.source = ""
> -
> +     resetData();
>      items.availablePieces.view.currentDisplayedGroup = 0

indentation

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D27728

To: shubhammishra, jjazeix, echarruau, timotheegiet, #gcompris_improvements
Cc: jjazeix, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200325/3891d263/attachment.html>