<table><tr><td style="">jjazeix added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27728">View Revision</a></tr></table><br /><div><div><p>Except those small changes, looks good to me.<br />
<a href="https://phabricator.kde.org/p/echarruau/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@echarruau</a>, <a href="https://phabricator.kde.org/p/timotheegiet/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@timotheegiet</a> any comment to add?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27728#inline-160750">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Babymatch.qml:94</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">id: bar</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span style="color: #aa4000">content:</span> <span style="color: #004012">BarEnumContent</span> <span class="p">{</span> <span style="color: #aa4000">value:</span> <span style="color: #004012">help</span> <span style="color: #aa2211">|</span> <span style="color: #004012">home</span> <span style="color: #aa2211">|</span> <span style="color: #004012">level</span> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">content:</span> <span style="color: #004012">BarEnumContent</span> <span class="p">{</span> <span style="color: #aa4000">value:</span> <span class="bright"></span><span style="color: #004012"><span class="bright">useMultipleDataset</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">help</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">|</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">home</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">|</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">level</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">|</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">activityConfig :</span></span><span class="bright"> </span><span style="color: #004012">help</span> <span style="color: #aa2211">|</span> <span style="color: #004012">home</span> <span style="color: #aa2211">|</span> <span style="color: #004012">level</span> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">onHelpClicked:</span> <span class="p">{</span><span style="color: #004012">displayDialog</span><span class="p">(</span><span style="color: #004012">dialogHelp</span><span class="p">)}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">use parenthesis to separate the different values</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27728#inline-160748">View Inline</a><span style="color: #4b4d51; font-weight: bold;">babymatch.js:79</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #004012">useMultipleDataset</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">var</span> <span style="color: #004012">filename</span> <span style="color: #aa2211">=</span> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">levels</span><span class="p">[</span><span style="color: #004012">currentLevel</span><span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">][</span><span style="color: #004012">currentSubLevel</span><span class="p">];</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">else</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you can directly set items.dataset.source here and below</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27728#inline-160749">View Inline</a><span style="color: #4b4d51; font-weight: bold;">babymatch.js:84</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">var</span> <span style="color: #004012">levelData</span> <span style="color: #aa2211">=</span> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">dataset</span><span class="p">.</span><span style="color: #004012">item</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">     <span style="color: #004012">resetData</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">availablePieces</span><span class="p">.</span><span style="color: #004012">view</span><span class="p">.</span><span style="color: #004012">currentDisplayedGroup</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">indentation</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27728">https://phabricator.kde.org/D27728</a></div></div><br /><div><strong>To: </strong>shubhammishra, jjazeix, echarruau, timotheegiet, GCompris: Improvements<br /><strong>Cc: </strong>jjazeix, kde-edu, narvaez, apol<br /></div>