D27583: rebuild mosaic multiple dataset

Deepak Kumar noreply at phabricator.kde.org
Mon Mar 9 19:14:01 GMT 2020

dekumar added inline comments.


> jjazeix wrote in Mosaic.qml:70
> it seems to be a string?

It's a typo. I would fixed it.

> jjazeix wrote in Mosaic.qml:145
> why (column.horizontal ? 1 : 1)?

I am making changes to the layout using different states. This issue would be fixed when I shall update the diff.

> jjazeix wrote in Data.qml:33
> it's not intuitive, we don't know what it means or does. Can you rename it?

Yeah, sure. What do you think of renaming is as "multipledataType" ??

  R2 GCompris


To: dekumar, #gcompris_improvements, jjazeix, timotheegiet, echarruau
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200309/a04a13d4/attachment.html>

More information about the kde-edu mailing list