D27583: rebuild mosaic multiple dataset

[Johnny Jazeix]

jjazeix added a comment.


  I'm wondering if we should not have the image names in the dataset too so later we can choose which images to display

INLINE COMMENTS

> Mosaic.qml:70
> +            property int questionLayoutRows
> +            property var dataType
>          }

it seems to be a string?

> Mosaic.qml:145
>                  spacing: 10
> -                columns: column.horizontal ? 2 : 1
> +                columns: column.verticalMode  ? (column.horizontal ? 1 : 1) : (column.horizontal ? 2 : 1)
>  

why (column.horizontal ? 1 : 1)?

> Data.qml:33
> +            ],
> +            "dataType": "data1"
> +

it's not intuitive, we don't know what it means or does. Can you rename it?

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D27583

To: dekumar, #gcompris_improvements, jjazeix, timotheegiet, echarruau
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200309/7bcb1c49/attachment.html>