D26637: balance scales multiple dataset

Deepak Kumar noreply at phabricator.kde.org
Sun Jan 26 08:36:15 GMT 2020


dekumar marked an inline comment as done.
dekumar added inline comments.

INLINE COMMENTS

> echarruau wrote in scalesboard.js:81
> Why do we need initCompleted here? Is displayLevel so slow that we it is possible for the user to click on ok button before displayLevel is executed? Just a question for my own knowledge :)

@echarruau I think just to check that the level has been displayed properly or not. As it is a boolean used in the function displaylevel() and it is true after all the items of the level has been loaded.

> jjazeix wrote in Data.qml:24
> keep the consistency for all datasets for the objective.
> Always use g or grams, kg or kilograms but not a mix

Sure, I would take care of that in further multipledata.

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D26637

To: dekumar, #gcompris_improvements, jjazeix, echarruau, timotheegiet
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200126/fd5da64f/attachment.html>


More information about the kde-edu mailing list