D26637: balance scales multiple dataset

[Johnny Jazeix]

jjazeix added a comment.


  Please fix these:
  
    git apply balancescale.diff 
    balancescale.diff:294: new blank line at EOF.
    +
    balancescale.diff:375: new blank line at EOF.
    +
    balancescale.diff:469: new blank line at EOF.
    +
    balancescale.diff:563: new blank line at EOF.
    +
    balancescale.diff:677: new blank line at EOF.
    +
    warning: squelched 2 whitespace errors
    warning: 7 lines add whitespace errors.
  
  The last activity of balancescales does not work anymore: qrc:/gcompris/src/activities/scalesboard_weight_avoirdupois/ScalesboardWeight.qml:35:5: Cannot assign to non-existent property "dataset"

INLINE COMMENTS

> Scalesboard.qml:247
> +
> +            property bool hasText: items.question.text ? true : false
> +        }

(items.question.text !== "")

> Data.qml:24
> +Dataset {
> +    objective: qsTr("Balance the scales until 10grams.")
> +    difficulty: 2

keep the consistency for all datasets for the objective.
Always use g or grams, kg or kilograms but not a mix

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D26637

To: dekumar, #gcompris_improvements, jjazeix, echarruau, timotheegiet
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200125/fe285d55/attachment-0001.html>