D26333: Fix assertion failure when creating a python script in kig

Kevin Kofler noreply at phabricator.kde.org
Wed Jan 1 14:50:41 GMT 2020


kkofler added inline comments.

INLINE COMMENTS

> narvaez wrote in python_scripter.cc:530
> Is there any valid case in which (objectvect.begin() + i)->ptr() is NULL? According to the Python documentation we only need XINCREF if the argument may be NULL, otherwise we can use Py_INCREF.

I don't know. I suspect not, but on the other hand, having the null check is safer. But if you are sure the null check is redundant, then it should be safe to change this.

REPOSITORY
  R331 Kig

REVISION DETAIL
  https://phabricator.kde.org/D26333

To: paolini, #kde_edu, kkofler
Cc: narvaez, kde-edu, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200101/0a8ddace/attachment-0001.html>


More information about the kde-edu mailing list