D26333: Fix assertion failure when creating a python script in kig

David Narváez noreply at phabricator.kde.org
Wed Jan 1 14:48:08 GMT 2020


narvaez added a reviewer: kkofler.
narvaez added inline comments.

INLINE COMMENTS

> python_scripter.cc:530
>      {
> +      Py_XINCREF((objectvect.begin() +i)->ptr());
>        PyTuple_SetItem( argstuph.get(), i, (objectvect.begin() +i)->ptr() );

Is there any valid case in which (objectvect.begin() + i)->ptr() is NULL? According to the Python documentation we only need XINCREF if the argument may be NULL, otherwise we can use Py_INCREF.

REPOSITORY
  R331 Kig

REVISION DETAIL
  https://phabricator.kde.org/D26333

To: paolini, #kde_edu, kkofler
Cc: narvaez, kde-edu, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200101/e2642416/attachment.html>


More information about the kde-edu mailing list