D27413: Fixed Equinox and Solstice dates in Calculator

[Jasem Mutlaq]

mutlaqja requested changes to this revision.
mutlaqja added a comment.
This revision now requires changes to proceed.


  Nice bug fix! I haven't tested the changes yet, just please check the commit and update accordignly.

INLINE COMMENTS

> modcalcvizequinox.h:51
>      void addDateAxes();
> -    KStarsDateTime findEquinox(int year, bool Spring, KPlotObject *po);
> -    KStarsDateTime findSolstice(int year, bool Summer);
> +    KStarsDateTime findSolsticeOrEquinox(int year, short n);
>  

What's n? use a better variable name.

Also what's the range for n? for year, we prefer to use uint32_t, int32_t...etc, not just int, short.

Add a comment block on top to explain what the function does ..etc in the standard doxygen format we use.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D27413

To: paritosh, mutlaqja
Cc: mutlaqja, kde-edu, zyziuk, ageoroceanu, smoe, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200216/131ad8ae/attachment.html>