<table><tr><td style="">mutlaqja requested changes to this revision.<br />mutlaqja added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27413">View Revision</a></tr></table><br /><div><div><p>Nice bug fix! I haven't tested the changes yet, just please check the commit and update accordignly.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27413#inline-154832">View Inline</a><span style="color: #4b4d51; font-weight: bold;">modcalcvizequinox.h:51</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">void</span> <span style="color: #004012">addDateAxes</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">KStarsDateTime</span> <span style="color: #004012">findEquinox</span><span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">year</span><span class="p">,</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">bool</span></span><span class="bright"> </span><span class="n"><span class="bright">Spring</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">KPlotObject</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"></span><span class="n"><span class="bright">po</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">KStarsDateTime</span> <span style="color: #004012">findSolstice</span><span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">year</span><span class="p">,</span> <span style="color: #aa4000">bool</span> <span class="n">Summer</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">KStarsDateTime</span> <span style="color: #004012">find<span class="bright">SolsticeOr</span>Equinox</span><span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">year</span><span class="p">,</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">short</span></span><span class="bright"> </span><span class="n"><span class="bright">n</span></span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">What's n? use a better variable name.</p>

<p style="padding: 0; margin: 8px;">Also what's the range for n? for year, we prefer to use uint32_t, int32_t...etc, not just int, short.</p>

<p style="padding: 0; margin: 8px;">Add a comment block on top to explain what the function does ..etc in the standard doxygen format we use.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27413">https://phabricator.kde.org/D27413</a></div></div><br /><div><strong>To: </strong>paritosh, mutlaqja<br /><strong>Cc: </strong>mutlaqja, kde-edu, zyziuk, ageoroceanu, smoe, narvaez, apol<br /></div>