D29008: Use the mount Pier Side property to manage Pier Flip

Jasem Mutlaq noreply at phabricator.kde.org
Wed Apr 22 07:00:40 BST 2020

mutlaqja added inline comments.


> TallFurryMan wrote in capture.cpp:6831
> Prototype `char const * Capture::MFStageString(MFStage stage) const` is more appropriate?
> That function has no interest in providing a QString object.
> Also, these strings are used in logs, so you may want to output something more friendly?

Isn't this getting casted to QString? I saw we avoid C strings in the code. Perhaps the only change required here is more friendly names.

  R321 KStars


To: chrisrowland, mutlaqja
Cc: TallFurryMan, wreissenberger, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200422/79f42a57/attachment.html>

More information about the kde-edu mailing list