D24257: PHD2 Enhancements

[Wolfgang Reissenberger]

wreissenberger requested changes to this revision.
wreissenberger added a comment.


  With "receive external guide frames" selected:
  
  1. pushing the "Capture" button in the Guide module creates an assertion failure in `PHD2::captureSingleFrame()`.
  2. pushing the "Loop" button shows the warning "PHD2 Error: could not start looping", but PHD2 starts looping.

INLINE COMMENTS

> phd2.cpp:70
>      //Only some of the methods are implemented.  The ones that say COMMAND_RECEIVED simply return a 0 saying the command was received.
>      //capture_single_frame
>      methodResults["clear_calibration"]      = CLEAR_CALIBRATION_COMMAND_RECEIVED;

Has to be defined here as methodResults[] member, otherwise `sendPHD2Request()` has an assertion failure when called from `PHD2::captureSingleFrame()`.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D24257

To: lancaster, mutlaqja, alexcherney, TallFurryMan, wreissenberger
Cc: hansl, wreissenberger, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190930/41ebb7d5/attachment.html>