D23830: Port away from KHTML

Tue Sep 10 17:02:47 BST 2019

yurchor added inline comments.

INLINE COMMENTS

> detailinfodlg.cpp:154
>  {
> -    QString html =
> -        "<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01 Transitional//EN\" \"http://www.w3.org/TR/html4/loose.dtd\">"
> -        "<html><head><title>Chemical data</title>"
> -        "<link rel=\"stylesheet\" type=\"text/css\" href=\"file://" + m_baseHtml + "style.css\" />"
> -        "<base href=\"" + m_baseHtml + "\"/></head><body>"
> -        "<div class=\"chemdata\"><div><table summary=\"header\" class=\"header\">"
> -        "<tr><td>" + m_element->dataAsString(ChemicalDataObject::symbol) + "</td><td>"
> -        + createWikiLink(m_element->dataAsString(ChemicalDataObject::name)) + "</td><td>"
> -        + i18n("Block: %1", m_element->dataAsString(ChemicalDataObject::periodTableBlock)) +
> -        "</td></tr></table></div>"
> -        "<table summary=\"characteristics\" class=\"characterstics\">";
> +    QString html = "<table width=\"100%\" summary=\"characteristics\">";
>  

Element info window now looks like Kalzium developers hate their creature. Unstylish, flat and dull.

Can we keep just a bit of powerful HTML5 styling? WebKit is much more advanced rendering engine than KHTML after all...

Just my 2 cents.

Before:
F7337958: kalz.png <https://phabricator.kde.org/F7337958>

After:
F7337959: kalzium2.png <https://phabricator.kde.org/F7337959>

REPOSITORY
  R326 Kalzium

REVISION DETAIL
  https://phabricator.kde.org/D23830

To: cordlandwehr, #kde_edu, apol
Cc: yurchor, aacid, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190910/a02d2326/attachment-0001.html>