D23656: Adding Slew and Sync telescope to top level right click menu

[Jasem Mutlaq]

mutlaqja requested changes to this revision.
mutlaqja added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> fitslabel.cpp:282
>                              pmenu->removeAction(action);
> +                        if (action->text().left(4) == "Slew")
> +                            pmenu->removeAction(action);

So most people would probably want "Track" and not "Slew" action. Slew is Go to object X, but do not engage tracking.

Track is Slew + engage tracking again once you arrive. Also, are these menu options always there? IMO, they should only be there if there is at least one mount connection.

Also, there should be a way to identify these are "Mount" Slew and "Mount" Sync somehow

Maybe "Slew Telescope" or "Track in Telescope", or "Mount Go to".. same thing for Sync.

> kspopupmenu.cpp:365
> +                    addAction(i18nc("Sync %1", "Sync %1").arg(gd->getDeviceName()), this, [this, gd, telescope] {
> +                        if (KMessageBox::warningYesNo(
> +                                    nullptr, i18n("Are you sure you want to Sync your Telescope on this position?"),

We should probably use the new system based on timers than a straight KMessageBox which can block.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D23656

To: lancaster, mutlaqja
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190902/1ecfadad/attachment-0001.html>