<table><tr><td style="">mutlaqja requested changes to this revision.<br />mutlaqja added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23656">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23656#inline-133611">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fitslabel.cpp:282</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                            <span class="n">pmenu</span><span style="color: #aa2211">-></span><span class="n">removeAction</span><span class="p">(</span><span class="n">action</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">action</span><span style="color: #aa2211">-></span><span class="n">text</span><span class="p">().</span><span class="n">left</span><span class="p">(</span><span style="color: #601200">4</span><span class="p">)</span> <span style="color: #aa2211">==</span> <span style="color: #766510">"Slew"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                            <span class="n">pmenu</span><span style="color: #aa2211">-></span><span class="n">removeAction</span><span class="p">(</span><span class="n">action</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">So most people would probably want "Track" and not "Slew" action. Slew is Go to object X, but do not engage tracking.</p>

<p style="padding: 0; margin: 8px;">Track is Slew + engage tracking again once you arrive. Also, are these menu options always there? IMO, they should only be there if there is at least one mount connection.</p>

<p style="padding: 0; margin: 8px;">Also, there should be a way to identify these are "Mount" Slew and "Mount" Sync somehow</p>

<p style="padding: 0; margin: 8px;">Maybe "Slew Telescope" or "Track in Telescope", or "Mount Go to".. same thing for Sync.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23656#inline-133610">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kspopupmenu.cpp:365</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span class="n">addAction</span><span class="p">(</span><span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"Sync %1"</span><span class="p">,</span> <span style="color: #766510">"Sync %1"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">gd</span><span style="color: #aa2211">-></span><span class="n">getDeviceName</span><span class="p">()),</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">gd</span><span class="p">,</span> <span class="n">telescope</span><span class="p">]</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">KMessageBox</span><span style="color: #aa2211">::</span><span class="n">warningYesNo</span><span class="p">(</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                    <span style="color: #aa4000">nullptr</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Are you sure you want to Sync your Telescope on this position?"</span><span class="p">),</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We should probably use the new system based on timers than a straight KMessageBox which can block.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23656">https://phabricator.kde.org/D23656</a></div></div><br /><div><strong>To: </strong>lancaster, mutlaqja<br /><strong>Cc: </strong>kde-edu, narvaez, apol<br /></div>