D25060: Fixing ASTAP Path on OS X and Setting Autostar as default for PHD2 Guiding

[Hy Murveit]

murveit added a comment.


  @wreissenberger: I reported the issue to Rob. The issue comes up only if the "auto star" button is unchecked in the Guide tab.  For me, 4 or 5 nights in a row last week I failed to guide after a meridian flip until I looked into the code and logs and discovered the root cause.
  
  @rlancaste: I tested last night with your patch, and had no issues, even though "auto star" was unchecked. It worked!
  Also, to address your comments:
  1- I'm fine with your PR in general and would OK if it got submitted.
  2- I agree that you should consider removing you change in setStatus(). what i meant to say was that *new installations* should default to having auto-star be checked.
  
  All:  In the guideAfterMeridianFlip() method, I would think that this same issue should affect the native guider, so I recommend looking into removing "if(guiderType == GUIDE_PHD2)" and would think that "autoStarCheck->setChecked(true);" should be applied to all guiders, but i haven't tested with other guiders, so can't say for sure.
  
  Hy

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D25060

To: lancaster, mutlaqja
Cc: wreissenberger, murveit, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20191030/a4ab4e75/attachment.html>