D25060: Fixing ASTAP Path on OS X and Setting Autostar as default for PHD2 Guiding

[Robert Lancaster]

lancaster added a comment.


  1- In the new method, Guide::guideAfterMeridianFlip(): Why would the issue be only related to PHD2? Wouldn't the internal guider also have the same issue? That is, after a meridian flip, the guide star's image position would change either when using PHD2 or with the native guider, so I would think you'd want to remove the "if(guiderType == GUIDE_PHD2)" test, and simply set autoStarCheck->setChecked(true); in either case.
  
  --I don't know the answer to this.  I don't usually use the internal guider.  Basically I put the check there because I didn't want to mess up any already existing behavior in the internal guider without asking first.  Though if Jasem and others who use and wrote the internal guider thing that its fine, then no problem

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D25060

To: lancaster, mutlaqja
Cc: wreissenberger, murveit, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20191030/d2053c9b/attachment.html>