D25138: Keeping track of download times for more reliable time estimates.

[Wolfgang Reissenberger]

wreissenberger accepted this revision.
wreissenberger added a comment.


  Looks good! I suggested a minor change, but we can survive without.

INLINE COMMENTS

> capture.cpp:4472-4473
>      if (job->getStatus() == SequenceJob::JOB_BUSY)
> -        remaining += (job->getExposure() + job->getDelay() / 1000) * (job->getCount() - job->getCompleted()) +
> -                     job->getExposeLeft();
> +        remaining += (job->getExposure() + getEstimatedDownloadTime() + job->getDelay() / 1000) * (job->getCount() - job->getCompleted()) +
> +                     job->getExposeLeft() + getEstimatedDownloadTime();
>      else

Could be shortened to

  int remaining = (job->getExposure() + getEstimatedDownloadTime() + job->getDelay() / 1000) * (job->getCount() - job->getCompleted());
  
  if (job->getStatus() == SequenceJob::JOB_BUSY)
  remaining += job->getExposeLeft() + getEstimatedDownloadTime();

REPOSITORY
  R321 KStars

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25138

To: lancaster, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20191104/1fb16820/attachment.html>