<table><tr><td style="">wreissenberger accepted this revision.<br />wreissenberger added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25138">View Revision</a></tr></table><br /><div><div><p>Looks good! I suggested a minor change, but we can survive without.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25138#inline-141926">View Inline</a><span style="color: #4b4d51; font-weight: bold;">capture.cpp:4472-4473</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">job</span><span style="color: #aa2211">-></span><span class="n">getStatus</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">SequenceJob</span><span style="color: #aa2211">::</span><span class="n">JOB_BUSY</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">remaining</span> <span style="color: #aa2211">+=</span> <span class="p">(</span><span class="n">job</span><span style="color: #aa2211">-></span><span class="n">getExposure</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">job</span><span style="color: #aa2211">-></span><span class="n">getDelay</span><span class="p">()</span> <span style="color: #aa2211">/</span> <span style="color: #601200">1000</span><span class="p">)</span> <span style="color: #aa2211">*</span> <span class="p">(</span><span class="n">job</span><span style="color: #aa2211">-></span><span class="n">getCount</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">job</span><span style="color: #aa2211">-></span><span class="n">getCompleted</span><span class="p">())</span> <span style="color: #aa2211">+</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                     <span class="n">job</span><span style="color: #aa2211">-></span><span class="n">getExposeLeft</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">remaining</span> <span style="color: #aa2211">+=</span> <span class="p">(</span><span class="n">job</span><span style="color: #aa2211">-></span><span class="n">getExposure</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="bright"></span><span class="n"><span class="bright">getEstimatedDownloadTime</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="n">job</span><span style="color: #aa2211">-></span><span class="n">getDelay</span><span class="p">()</span> <span style="color: #aa2211">/</span> <span style="color: #601200">1000</span><span class="p">)</span> <span style="color: #aa2211">*</span> <span class="p">(</span><span class="n">job</span><span style="color: #aa2211">-></span><span class="n">getCount</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">job</span><span style="color: #aa2211">-></span><span class="n">getCompleted</span><span class="p">())</span> <span style="color: #aa2211">+</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                     <span class="n">job</span><span style="color: #aa2211">-></span><span class="n">getExposeLeft</span><span class="p">()<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="n"><span class="bright">getEstimatedDownloadTime</span></span><span class="bright"></span><span class="p"><span class="bright">()</span>;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">else</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Could be shortened to</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">int remaining = (job->getExposure() + getEstimatedDownloadTime() + job->getDelay() / 1000) * (job->getCount() - job->getCompleted());

if (job->getStatus() == SequenceJob::JOB_BUSY)
remaining += job->getExposeLeft() + getEstimatedDownloadTime();</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25138">https://phabricator.kde.org/D25138</a></div></div><br /><div><strong>To: </strong>lancaster, mutlaqja, wreissenberger<br /><strong>Cc: </strong>kde-edu, narvaez, apol<br /></div>