D21496: Two Sample T-test Backend

[Stefan Gerlach]

sgerlach added inline comments.

INLINE COMMENTS

> TTest.cpp:56
> +
> +    // use of three than two for human readiblity of code;
> +    int n[3];

is this really necessary? In C++ starting from 0 is expected.

> TTest.cpp:81
> +    double t = (mean[1] - mean[2])/(sp*qSqrt(1.0/n[1] + 1.0/n[2]));
> +    QString text = i18n("T value for test is %0").arg(t);
> +    msg_box->setText(text);

use "," instead of arg(). See https://techbase.kde.org/Development/Tutorials/Localization/i18n for more details.

> TTest.cpp:96
> +    count = column->rowCount();
> +    for(int i=0; i<count; i++) {
> +        double row = column->valueAt(i);

use spaces: for (int i = 0; i < count; i++)

> TTest.cpp:108
> +
> +    for(int i=0; i<count; i++) {
> +        double row = column->valueAt(i);

spaces.

> TTest.h:24
> +    int m_columns{0};
> +    QVector<Column*> columns;
> +};

all private member names should start with m_

> SpreadsheetView.cpp:782
> +{
> +    TTest* ttest = new TTest(i18n("doing T Test for %1", m_spreadsheet->name()));
> +    ttest->setColumns(this->selectedColumns());

here it is correctly translated :-)

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D21496

To: devanshuagarwal, sgerlach
Cc: kde-edu, #labplot, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190530/0d253c51/attachment-0001.html>