<table><tr><td style="">sgerlach added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21496">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21496#inline-120738">View Inline</a><span style="color: #4b4d51; font-weight: bold;">TTest.cpp:56</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">// use of three than two for human readiblity of code;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">int</span> <span class="n">n</span><span class="p">[</span><span style="color: #601200">3</span><span class="p">];</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">is this really necessary? In C++ starting from 0 is expected.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21496#inline-120735">View Inline</a><span style="color: #4b4d51; font-weight: bold;">TTest.cpp:81</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">double</span> <span class="n">t</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span class="n">mean</span><span class="p">[</span><span style="color: #601200">1</span><span class="p">]</span> <span style="color: #aa2211">-</span> <span class="n">mean</span><span class="p">[</span><span style="color: #601200">2</span><span class="p">])</span><span style="color: #aa2211">/</span><span class="p">(</span><span class="n">sp</span><span style="color: #aa2211">*</span><span class="n">qSqrt</span><span class="p">(</span><span style="color: #601200">1.0</span><span style="color: #aa2211">/</span><span class="n">n</span><span class="p">[</span><span style="color: #601200">1</span><span class="p">]</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1.0</span><span style="color: #aa2211">/</span><span class="n">n</span><span class="p">[</span><span style="color: #601200">2</span><span class="p">]));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QString</span> <span class="n">text</span> <span style="color: #aa2211">=</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"T value for test is %0"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">t</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">msg_box</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">text</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">use "," instead of arg(). See <a href="https://techbase.kde.org/Development/Tutorials/Localization/i18n" class="remarkup-link" target="_blank" rel="noreferrer">https://techbase.kde.org/Development/Tutorials/Localization/i18n</a> for more details.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21496#inline-120739">View Inline</a><span style="color: #4b4d51; font-weight: bold;">TTest.cpp:96</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">count</span> <span style="color: #aa2211">=</span> <span class="n">column</span><span style="color: #aa2211">-></span><span class="n">rowCount</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">for</span><span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">i</span><span style="color: #aa2211">=</span><span style="color: #601200">0</span><span class="p">;</span> <span class="n">i</span><span style="color: #aa2211"><</span><span class="n">count</span><span class="p">;</span> <span class="n">i</span><span style="color: #aa2211">++</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">double</span> <span class="n">row</span> <span style="color: #aa2211">=</span> <span class="n">column</span><span style="color: #aa2211">-></span><span class="n">valueAt</span><span class="p">(</span><span class="n">i</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">use spaces: for (int i = 0; i < count; i++)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21496#inline-120741">View Inline</a><span style="color: #4b4d51; font-weight: bold;">TTest.cpp:108</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">for</span><span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">i</span><span style="color: #aa2211">=</span><span style="color: #601200">0</span><span class="p">;</span> <span class="n">i</span><span style="color: #aa2211"><</span><span class="n">count</span><span class="p">;</span> <span class="n">i</span><span style="color: #aa2211">++</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">double</span> <span class="n">row</span> <span style="color: #aa2211">=</span> <span class="n">column</span><span style="color: #aa2211">-></span><span class="n">valueAt</span><span class="p">(</span><span class="n">i</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">spaces.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21496#inline-120737">View Inline</a><span style="color: #4b4d51; font-weight: bold;">TTest.h:24</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">int</span> <span class="n">m_columns</span><span class="p">{</span><span style="color: #601200">0</span><span class="p">};</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QVector</span><span style="color: #aa2211"><</span><span class="n">Column</span><span style="color: #aa2211">*></span> <span class="n">columns</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">};</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">all private member names should start with m_</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21496#inline-120742">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SpreadsheetView.cpp:782</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">TTest</span><span style="color: #aa2211">*</span> <span class="n">ttest</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">TTest</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"doing T Test for %1"</span><span class="p">,</span> <span class="n">m_spreadsheet</span><span style="color: #aa2211">-></span><span class="n">name</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">ttest</span><span style="color: #aa2211">-></span><span class="n">setColumns</span><span class="p">(</span><span style="color: #aa4000">this</span><span style="color: #aa2211">-></span><span class="n">selectedColumns</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">here it is correctly translated :-)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R262 LabPlot</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21496">https://phabricator.kde.org/D21496</a></div></div><br /><div><strong>To: </strong>devanshuagarwal, sgerlach<br /><strong>Cc: </strong>kde-edu, LabPlot, narvaez, apol<br /></div>