D20029: Capture counting corrected

Eric Dejouhanet noreply at phabricator.kde.org
Wed Mar 27 08:08:30 GMT 2019


TallFurryMan added a comment.


  In D20029#438502 <https://phabricator.kde.org/D20029#438502>, @wreissenberger wrote:
  
  > By the way: I found out that the null pointer exception occurs also when there is only one scheduler entry. So I think it's quite urgent that we at least fix this issue...
  
  
  Agreed! I've been hit by exactly this yesterday evening, using a build that was one month old.
  My dumb brain needs to agree with you on capture_completed, and we're good to go.
  Unless maybe you split your diff into two to manage findNextJob in one of them and the duration estimation in the other?
  There's a need on splitting evaluateJobs into a real job evaluation and the runtime selection that should be in findNextJob, if you see what I mean.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D20029

To: wreissenberger, mutlaqja, TallFurryMan
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190327/f534e98c/attachment.html>


More information about the kde-edu mailing list