D20068: Shifted scheduler job specific scorings from Scheduler to SchedulerJob

[Eric Dejouhanet]

TallFurryMan accepted this revision.
TallFurryMan added a comment.
This revision is now accepted and ready to land.


  I cannot disagree with this, this is what you proposed last year, and this is the approach I support!
  Obviously we need to be very careful to not moving the complexity from one class to the other.

INLINE COMMENTS

> schedulerjob.h:27
>    public:
> -    SchedulerJob() = default;
> +    SchedulerJob();
>  

Huh, what was that "default" I didn't know about? C++11 specificities?

> schedulerjob.h:504
> +    /// Pointer to Moon object
> +    KSMoon *moon { nullptr };
>  };

Perhaps make it static?

REPOSITORY
  R321 KStars

BRANCH
  lean_scheduler

REVISION DETAIL
  https://phabricator.kde.org/D20068

To: wreissenberger, mutlaqja, TallFurryMan
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190327/6181edf7/attachment.html>