D20068: Shifted scheduler job specific scorings from Scheduler to SchedulerJob

[Wolfgang Reissenberger]

wreissenberger created this revision.
wreissenberger added reviewers: mutlaqja, TallFurryMan.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
wreissenberger requested review of this revision.

REVISION SUMMARY
  Currently, the scheduler is a class with more than 7200 lines of code which makes it very tricky to maintain. This approach follows the idea shift job specific scorings from Scheduler to SchedulerJob:
  
  - altitude scoring
  - culmination scoring
  - moon separation
  
  This is an alternative (simpler) approach to D20001 <https://phabricator.kde.org/D20001>.

TEST PLAN
  Well, this is the downside of this refactoring effort. Since the Scheduler is awfully complex and intertwined, it needs to be tested carefully.
  
  At least from the intention, the execution of scheduler jobs should not be touched, only the correct calculations of scores. So please test all combinations that have effect to the score of a scheduler job.

REPOSITORY
  R321 KStars

BRANCH
  lean_scheduler

REVISION DETAIL
  https://phabricator.kde.org/D20068

AFFECTED FILES
  kstars/ekos/scheduler/scheduler.cpp
  kstars/ekos/scheduler/scheduler.h
  kstars/ekos/scheduler/schedulerjob.cpp
  kstars/ekos/scheduler/schedulerjob.h

To: wreissenberger, mutlaqja, TallFurryMan
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190326/dee9d9d3/attachment.html>