D19393: Prevent rescheduling aborted jobs until all jobs are processed

[Eric Dejouhanet]

TallFurryMan added a comment.


  In D19393#428066 <https://phabricator.kde.org/D19393#428066>, @wreissenberger wrote:
  
  > Shall I give it a try?
  
  
  Sure, and I have suggestions :) let's do this really step by step. At the extreme, because the source is so complex, I'd say let's go function by function, ensuring that they match features.
  
  There are different stages I think:
  
  - Frame map consolidation. There is a local part in the job, and a consolidation part in the scheduler. Here job can be considered independent from scheduler I think. But it's easy to add regressions, as we observed last year.
  - Astronomical calculations for restrictions. It was difficult to make those independent from each other, and they rely on scheduler properties, so prototypes will be tricky. Besides, calculating some values in the future like dawn and dusk is still completely bugged. We won't be able to do that in one step.
  - Job state manipulation. This was mostly covered last year, but may still be fragile.
  - Serialization to/from storage. We had a discussion last year about switching to QT serialization instead of manipulating files. Should be a good opportunity to move forward.
  - Relation with sequence files. If we move that part we can do far better in terms of storage organization. For instance, it's annoying to require the end-user to build a sequence file with a target folder before a scheduler job can be started. The sequence file would still need the correct CCD to be connected to Ekos prior to be used, but at least we could start templating sequences used in the scheduler, replacing a few values only. That is too difficult to do for now with the code as it is.
  
  As a side note I want to make all jobs except the running one editable while scheduler is running, so that we'll be able to read schedules from an external source. Will be easier when code is moved away.

REPOSITORY
  R321 KStars

BRANCH
  improve__bypass_aborted_jobs_while_running (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19393

To: TallFurryMan, mutlaqja, wreissenberger
Cc: mutlaqja, wreissenberger, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190310/c67fe226/attachment.html>