D21710: Add multiple datasets to smallnumbers activity

[Sagar Chand Agarwal]

scagarwal requested changes to this revision.
scagarwal added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> Gletters.qml:89
>              property GCAudio audioVoices: activity.audioVoices
> +            property var levels: activity.datasetLoader.item !== null ? activity.datasetLoader.item.data : undefined
>              property alias background: background

Do not use `undefined` . Please use `null`

> gletters.js:79
>      GCompris.DownloadManager.updateResource(GCompris.DownloadManager.getVoicesResourceForLocale(GCompris.ApplicationInfo.getVoicesLocale(items.locale)));
> -
> -    items.wordlist.loadFromFile(GCompris.ApplicationInfo.getLocaleFilePath(
> +    if(items.levels == undefined)
> +        items.wordlist.loadFromFile(GCompris.ApplicationInfo.getLocaleFilePath(

`undefined` should not be used. better use `!items.levels`

> gletters.js:98
>          items.wordlist.useDefault = true
> -        items.wordlist.loadFromFile(GCompris.ApplicationInfo.getLocaleFilePath(
> -        items.ourActivity.dataSetUrl + "default-"+localeShort+".json"));
> +        if(items.levels == undefined)
> +            items.wordlist.loadFromFile(GCompris.ApplicationInfo.getLocaleFilePath(

`undefined` should not be used. better use `!items.levels`

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D21710

To: AkshayCHD, #gcompris_improvements, timotheegiet, scagarwal
Cc: scagarwal, amankumargupta, echarruau, timotheegiet, jjazeix, #gcompris_improvements, kde-edu, #gcompris, sanjayshetty, parimalprasoon, harrymecwan, ganeshredcobra, nityanandkumar, andreask, rahulyadav, narvaez, apol, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190619/a8fbb2cd/attachment-0001.html>