<table><tr><td style="">scagarwal requested changes to this revision.<br />scagarwal added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21710">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21710#inline-123282">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Gletters.qml:89</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">property</span> <span style="color: #004012">GCAudio</span> <span style="color: #aa4000">audioVoices:</span> <span style="color: #004012">activity</span><span class="p">.</span><span style="color: #004012">audioVoices</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">property</span> <span style="color: #aa4000">var</span> <span style="color: #aa4000">levels:</span> <span style="color: #004012">activity</span><span class="p">.</span><span style="color: #004012">datasetLoader</span><span class="p">.</span><span style="color: #004012">item</span> <span style="color: #aa2211">!==</span> <span style="color: #000a65">null</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">activity.datasetLoader.item.data :</span> <span style="color: #000a65">undefined</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">property</span> <span style="color: #004012">alias</span> <span style="color: #aa4000">background:</span> <span style="color: #004012">background</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Do not use <tt style="background: #ebebeb; font-size: 13px;">undefined</tt> . Please use <tt style="background: #ebebeb; font-size: 13px;">null</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21710#inline-123284">View Inline</a><span style="color: #4b4d51; font-weight: bold;">gletters.js:79</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">GCompris</span><span class="p">.</span><span style="color: #004012">DownloadManager</span><span class="p">.</span><span style="color: #004012">updateResource</span><span class="p">(</span><span style="color: #004012">GCompris</span><span class="p">.</span><span style="color: #004012">DownloadManager</span><span class="p">.</span><span style="color: #004012">getVoicesResourceForLocale</span><span class="p">(</span><span style="color: #004012">GCompris</span><span class="p">.</span><span style="color: #004012">ApplicationInfo</span><span class="p">.</span><span style="color: #004012">getVoicesLocale</span><span class="p">(</span><span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">locale</span><span class="p">)));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">wordlist</span><span class="p">.</span><span style="color: #004012">loadFromFile</span><span class="p">(</span><span style="color: #004012">GCompris</span><span class="p">.</span><span style="color: #004012">ApplicationInfo</span><span class="p">.</span><span style="color: #004012">getLocaleFilePath</span><span class="p">(</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"> </span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">items</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">levels</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">==</span></span><span class="bright"> </span><span style="color: #000a65"><span class="bright">undefined</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">wordlist</span><span class="p">.</span><span style="color: #004012">loadFromFile</span><span class="p">(</span><span style="color: #004012">GCompris</span><span class="p">.</span><span style="color: #004012">ApplicationInfo</span><span class="p">.</span><span style="color: #004012">getLocaleFilePath</span><span class="p">(</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">undefined</tt> should not be used. better use <tt style="background: #ebebeb; font-size: 13px;">!items.levels</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21710#inline-123285">View Inline</a><span style="color: #4b4d51; font-weight: bold;">gletters.js:98</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">wordlist</span><span class="p">.</span><span style="color: #004012">useDefault</span> <span style="color: #aa2211">=</span> <span style="color: #000a65">true</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">items</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">wordlist</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">loadFromFile</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">GCompris</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">ApplicationInfo</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">getLocaleFilePath</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">items</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">ourActivity</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">dataSetUrl</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"default-"</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">l</span>ocale<span class="bright">Short</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">".json"</span></span><span class="bright"></span><span class="p"><span class="bright">));</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">i<span class="bright">f</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">i</span>tems</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">levels</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">==</span></span><span class="bright"> </span><span style="color: #000a65"><span class="bright">undefined</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span style="color: #004012">items</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span style="color: #004012"><span class="bright">wordlist</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">loadFromFile</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">GCompris</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">ApplicationInfo</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">getL</span>ocale<span class="bright">FilePath</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">undefined</tt> should not be used. better use <tt style="background: #ebebeb; font-size: 13px;">!items.levels</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21710">https://phabricator.kde.org/D21710</a></div></div><br /><div><strong>To: </strong>AkshayCHD, GCompris: Improvements, timotheegiet, scagarwal<br /><strong>Cc: </strong>scagarwal, amankumargupta, echarruau, timotheegiet, jjazeix, GCompris: Improvements, kde-edu, GCompris, sanjayshetty, parimalprasoon, harrymecwan, ganeshredcobra, nityanandkumar, andreask, rahulyadav, narvaez, apol, bcoudoin<br /></div>