D21461: Multiplle datasets for money activity

[Aman Kumar Gupta]

amankumargupta added inline comments.

INLINE COMMENTS

> money.js:47
> +            backMode = false
>          break
> +        case "WITH_CENTS":

Indentation for break. Same for the following breaks..

> money.js:88
> +
>      for (var i in pocket)
>          items.pocketModel.append(pocket[i])

Please follow the coding style everywhere and write a complete version of "for". Having "for" written in different ways everywhere is not uniform.

> money.js:185
>  function getRandomObject(price) {
>      var list
>      if(price < 5)

better rename it as "itemList" or "objectList"?

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D21461

To: AkshayCHD, #gcompris_improvements, scagarwal
Cc: amankumargupta, scagarwal, asagtani, jjazeix, kde-edu, #gcompris_improvements, sanjayshetty, parimalprasoon, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, andreask, rahulyadav, narvaez, apol, timotheegiet, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190608/fb3587bd/attachment.html>