<table><tr><td style="">amankumargupta added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21461">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21461#inline-121856">View Inline</a><span style="color: #4b4d51; font-weight: bold;">money.js:47</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #004012"><span class="bright">cents</span>Mode</span> <span style="color: #aa2211">=</span> <span style="color: #000a65">false</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">backMode</span> <span style="color: #aa2211">=</span> <span style="color: #000a65">false</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span style="color: #004012"><span class="bright">back</span>Mode</span> <span style="color: #aa2211">=</span> <span style="color: #000a65">false</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">break</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">case</span> <span style="color: #766510">"WITH_CENTS"</span><span style="color: #aa2211">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span style="color: #aa4000">case</span> <span style="color: #766510">"WITH_CENTS"</span><span style="color: #aa2211">:</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Indentation for break. Same for the following breaks..</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21461#inline-121857">View Inline</a><span style="color: #4b4d51; font-weight: bold;">money.js:88</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">var</span> <span style="color: #004012">i</span> <span style="color: #aa4000">in</span> <span style="color: #004012">pocket</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">pocketModel</span><span class="p">.</span><span style="color: #004012">append</span><span class="p">(</span><span style="color: #004012">pocket</span><span class="p">[</span><span style="color: #004012">i</span><span class="p">])</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please follow the coding style everywhere and write a complete version of "for". Having "for" written in different ways everywhere is not uniform.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21461#inline-121860">View Inline</a><span style="color: #4b4d51; font-weight: bold;">money.js:185</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #aa4000">function</span> <span style="color: #004012">getRandomObject</span><span class="p">(</span><span style="color: #004012">price</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">var</span> <span style="color: #004012">list</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #004012">price</span> <span style="color: #aa2211"><</span> <span style="color: #601200">5</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">better rename it as "itemList" or "objectList"?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21461">https://phabricator.kde.org/D21461</a></div></div><br /><div><strong>To: </strong>AkshayCHD, GCompris: Improvements, scagarwal<br /><strong>Cc: </strong>amankumargupta, scagarwal, asagtani, jjazeix, kde-edu, GCompris: Improvements, sanjayshetty, parimalprasoon, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, andreask, rahulyadav, narvaez, apol, timotheegiet, bcoudoin<br /></div>