D21461: Multiplle datasets for money activity

[Johnny Jazeix]

jjazeix added a comment.


  I let the other mentors do a complete review, I only point out one improvement that would be great to have

INLINE COMMENTS

> money.js:141
>          var tuxMoney
>          switch(data.paid) {
>          case 5:

can this part be made generic (computed from the moneyItems of the current dataset)? For example, if we take the previous Italian money (https://en.wikipedia.org/wiki/Italian_lira), 1€ is around 2000 Lira so the prices had higher values.
If we do a switch case between 5 and 400, we won't be able to add a dataset for these prices.

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D21461

To: AkshayCHD, #gcompris_improvements
Cc: asagtani, jjazeix, kde-edu, #gcompris_improvements, sanjayshetty, parimalprasoon, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, andreask, rahulyadav, narvaez, scagarwal, apol, timotheegiet, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190604/aebc6345/attachment.html>