D22614: Correlation Coefficient (Pearson's r, Kendall Rank, Spearman Rank)

Devanshu Agarwal noreply at phabricator.kde.org
Mon Jul 22 17:29:13 BST 2019


devanshuagarwal marked 2 inline comments as done.
devanshuagarwal added inline comments.

INLINE COMMENTS

> sgerlach wrote in CorrelationCoefficient.h:36
> are all of them needed?

Thanks, I removed unnecessary ones.

> sgerlach wrote in HypothesisTest.cpp:158
> <= contradicts error message. Can std be < 0? (fix everywhere)

No std cant be < 0.

In starting I wrote

  if (std[i] == 0) {
  }

but then it shows warning. 
Comparing floating point with == or != is unsafe.

Hence I have used <=

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D22614

To: devanshuagarwal, sgerlach, asemke
Cc: kde-edu, #labplot, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190722/01889711/attachment.html>


More information about the kde-edu mailing list