D22614: Correlation Coefficient (Pearson's r, Kendall Rank, Spearman Rank)

[Stefan Gerlach]

sgerlach added inline comments.

INLINE COMMENTS

> CorrelationCoefficient.h:36
> +
> +class CorrelationCoefficientView;
> +class Spreadsheet;

are all of them needed?

> HypothesisTest.cpp:158
>              }
> -            if (std[i] == 0) {
> +            if (std[i] <= 0) {
>                  printError(i18n("Standard Deviation of atleast one column is equal to 0: last column is: %1", m_columns[i]->name()));

<= contradicts error message. Can std be < 0? (fix everywhere)

> HypothesisTest.cpp:159
> +            if (std[i] <= 0) {
>                  printError(i18n("Standard Deviation of atleast one column is equal to 0: last column is: %1", m_columns[i]->name()));
>                  return;

"atleast" -> "at least" (fix everywhere)

> CorrelationCoefficientDock.cpp:483
> +bool CorrelationCoefficientDock::nonEmptySelectedColumns() {
> +    if (ui.cbCol1->isVisible() && ui.cbCol1->count() < 1)
> +        return false;

you can combine all conditions in one if-statement

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D22614

To: devanshuagarwal, sgerlach, asemke
Cc: kde-edu, #labplot, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190722/a0dca7f1/attachment-0001.html>