D22640: Unit Testing for Pearson Correlation Coefficient

[Stefan Gerlach]

sgerlach added inline comments.

INLINE COMMENTS

> CorrelationCoefficientTest.cpp:36
> +    QTest::addColumn<QVector<double>>("col1Data");
> +	QTest::addColumn<QVector<double>>("col2Data");
> +    QTest::addColumn<double>("correlationValue_expected");

indentation looks strange again. Ignore if it's ok in your code.

> CorrelationCoefficientTest.cpp:101
> +
> +    QDEBUG("Correlation Value is " << correlationValue);
> +    QDEBUG("Correlation Value Expected is " << correlationValue_expected);

you can omit the ';' after QDEBUG

> CorrelationCoefficientTest.cpp:106
> +
> +    FuzzyCompare(correlationValue, correlationValue_expected, 0.1);
> +    FuzzyCompare(zValue, zValue_expected, 0.1);

10% error is a lot. Can you decrease it?

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D22640

To: devanshuagarwal, sgerlach
Cc: kde-edu, #labplot, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190722/f5d733fe/attachment.html>