<table><tr><td style="">sgerlach added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22640">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22640#inline-127892">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CorrelationCoefficientTest.cpp:36</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QTest</span><span style="color: #aa2211">::</span><span class="n">addColumn</span><span style="color: #aa2211"><</span><span class="n">QVector</span><span style="color: #aa2211"><</span><span style="color: #aa4000">double</span><span style="color: #aa2211">>></span><span class="p">(</span><span style="color: #766510">"col1Data"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QTest</span><span style="color: #aa2211">::</span><span class="n">addColumn</span><span style="color: #aa2211"><</span><span class="n">QVector</span><span style="color: #aa2211"><</span><span style="color: #aa4000">double</span><span style="color: #aa2211">>></span><span class="p">(</span><span style="color: #766510">"col2Data"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QTest</span><span style="color: #aa2211">::</span><span class="n">addColumn</span><span style="color: #aa2211"><</span><span style="color: #aa4000">double</span><span style="color: #aa2211">></span><span class="p">(</span><span style="color: #766510">"correlationValue_expected"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">indentation looks strange again. Ignore if it's ok in your code.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22640#inline-127893">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CorrelationCoefficientTest.cpp:101</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QDEBUG</span><span class="p">(</span><span style="color: #766510">"Correlation Value is "</span> <span style="color: #aa2211"><<</span> <span class="n">correlationValue</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QDEBUG</span><span class="p">(</span><span style="color: #766510">"Correlation Value Expected is "</span> <span style="color: #aa2211"><<</span> <span class="n">correlationValue_expected</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you can omit the ';' after QDEBUG</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22640#inline-127894">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CorrelationCoefficientTest.cpp:106</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">FuzzyCompare</span><span class="p">(</span><span class="n">correlationValue</span><span class="p">,</span> <span class="n">correlationValue_expected</span><span class="p">,</span> <span style="color: #601200">0.1</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">FuzzyCompare</span><span class="p">(</span><span class="n">zValue</span><span class="p">,</span> <span class="n">zValue_expected</span><span class="p">,</span> <span style="color: #601200">0.1</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">10% error is a lot. Can you decrease it?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R262 LabPlot</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22640">https://phabricator.kde.org/D22640</a></div></div><br /><div><strong>To: </strong>devanshuagarwal, sgerlach<br /><strong>Cc: </strong>kde-edu, LabPlot, narvaez, apol<br /></div>