D22507: Tooltip Framework for m_statsTable in HypothesisTestView

[Devanshu Agarwal]

devanshuagarwal marked an inline comment as done.
devanshuagarwal added inline comments.

INLINE COMMENTS

> asemke wrote in HypothesisTest.cpp:1578
> is currCell->data unique or can we have collisions here?

Yes, we can have collisions here but this is the best way I could come up yet. Another thing that we can do is to store tooltip with word position (local or global). But the challenge will be to find the position of the word in huge strings.

> asemke wrote in HypothesisTestPrivate.h:59
> you have quite a lot of parameters already in the constructor. Consider setting the tooltip via setToolTip() function. No need to add yet another empty parameter to the constructor.

Ok, It can be done. But I think it will make code unreadable and confusing:
For example this table horizontal header:

  rowMajor.append(new Cell("", level, true));
  rowMajor.append(new Cell("SS", level, true));
  rowMajor.append(new Cell("df", level, true, "degree of freedom");
  rowMajor.append(new Cell("MS", level, true));

will get changed to:

  rowMajor.append(new Cell("", level, true));
  rowMajor.append(new Cell("SS", level, true));
  Cell* newCell = new Cell("DF", level, true); newCell->setToolTip("Degree of Freedom"); rowMajor.append(newCell);
  rowMajor.append(new Cell("MS", level, true));

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D22507

To: devanshuagarwal, sgerlach, asemke
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190718/c9fa98cf/attachment.html>