D22496: Autmatic Test For Two Way ANOVA.

Devanshu Agarwal noreply at phabricator.kde.org
Thu Jul 18 10:46:42 BST 2019

devanshuagarwal marked an inline comment as done.
devanshuagarwal added inline comments.


> sgerlach wrote in HypothesisTest.cpp:304
> I would suggest to use sqrt() from cmath instead of qSqrt(). What do you think?

Yes you are right.

> sgerlach wrote in HypothesisTest.cpp:747
> you are doing a lot of basic statistical calculations. Can you check if any GSL function can be used (see https://www.gnu.org/software/gsl/doc/html/statistics.html)?

The reason that I am doing so many basic calculations is to increase performance. If I will use functions then I have to call separate functions for mean, std deviation and other statistical calculations. Though asymptotically it will also end up in O(n) but for practical purposes, it will turn out to be slower as here I am transversing through the whole data only twice and there it will be f times (where f >= number of statistical calculations)

> sgerlach wrote in HypothesisTest.cpp:843
> translation?

the translation is automatic in getHtmlTable3 function

> sgerlach wrote in HypothesisTest.cpp:849
> translation?

It is there in getHtmlTable3 method.

> sgerlach wrote in HypothesisTest.cpp:1375
> check indentation

It is indented in the source file. I don't know why it is not shown in the differnce file.

  R262 LabPlot


To: devanshuagarwal, Stefan, asemke
Cc: sgerlach, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190718/fe9fee6d/attachment.html>

More information about the kde-edu mailing list