D22389: Make Qt5X11Extras optional

Andreas Sturmlechner noreply at phabricator.kde.org
Thu Jul 11 07:35:45 BST 2019


asturmlechner added inline comments.

INLINE COMMENTS

> gottfried wrote in CMakeLists.txt:40
> Is it possible to reformulate this line like line 41 (without the QUIET, though)? I would prefer to request Qt features in a consistent way.

For optional dependencies, it is better to do it this way. Otherwise, if the dependency is disabled or not found, `Qt5_FOUND` is set to `0`, which does not necessarily lead to failure later on (it can, though) but at a minimum leads to conflicting `FeatureSummary` output (`Qt5 not found` or sth. along those lines).

REPOSITORY
  R336 KTouch

REVISION DETAIL
  https://phabricator.kde.org/D22389

To: asturmlechner, #kde_edu, gottfried
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190711/3f551ebe/attachment.html>


More information about the kde-edu mailing list