D22389: Make Qt5X11Extras optional

Sebastian Gottfried noreply at phabricator.kde.org
Thu Jul 11 07:28:54 BST 2019


gottfried requested changes to this revision.
gottfried added a comment.
This revision now requires changes to proceed.


  Thanks for the patch. If you change the dependencies in the CMake files, you also need to update the README so they stay in sync.

INLINE COMMENTS

> CMakeLists.txt:40
>  
> +find_package(Qt5X11Extras)
>  find_package(Qt5 CONFIG QUIET OPTIONAL_COMPONENTS QuickCompiler)

Is it possible to reformulate this line like line 41 (without the QUIET, though)? I would prefer to request Qt features in a consistent way.

REPOSITORY
  R336 KTouch

REVISION DETAIL
  https://phabricator.kde.org/D22389

To: asturmlechner, #kde_edu, gottfried
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190711/a1885357/attachment.html>


More information about the kde-edu mailing list