D17783: Add configuration menu in small numbers activity to support multiple domino types

[Akshay Kumar]

AkshayCHD added a comment.


  @jjazeix Sorry, but i didn't completely understand the above comment regarding translation, can you please explain. Thanks :)

INLINE COMMENTS

> jjazeix wrote in Gletters.qml:191
> would be better to get it from the visible property if you change the above behaviour.

@jjazeix It is not possible to do that in my opinion as, the onLoadData is called when the activity is loaded and the components of dialog activity have not been loaded at that time, that is why it gives me an error that dialogActivityConfig is undefined. It can be changed in onSave function but then keeping the values of if-else statement in the 2 functions different would not be good in my opinion as it would be harder to understand,

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D17783

To: AkshayCHD, #gcompris_improvements
Cc: jjazeix, kde-edu, #gcompris_improvements, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, bcoudoin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190124/88a5f618/attachment.html>