D18420: Optimize and reduce code in GuiObserver

Christoph Roick noreply at phabricator.kde.org
Wed Jan 23 23:29:15 GMT 2019

croick added a comment.

  I still prefer my solution ;)
  But I agree, that the enum would be more consistent with the rest of the project. Actually, `AbstractAspect` could have a `type()` function that contains the actual type (like in `AbstractFileFilter`). That would entirely spare the use of a map and string comparisons, but would require touching 20 constructors or so.
  What do you think?


> asemke wrote in GuiObserver.cpp:415
> as discussed in another email thread and in D18319 <https://phabricator.kde.org/D18319>,  we planned to show and to allow to modify the first selected LiveDataSource or MQTTClient only. Do we need another template function?

I would first like to finish this and later remove the loops entirely in the other patch to save some work. So there will be no need for another function.

  R262 LabPlot


To: croick, #labplot
Cc: asemke, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190123/0109302f/attachment-0001.html>

More information about the kde-edu mailing list