D18294: Algorithms to find values and indices in vectors of data

[Martin Marmsoler]

Murmele added a comment.


  In D18294#396744 <https://phabricator.kde.org/D18294#396744>, @rikmills wrote:
  
  > Causes build failures on KDE Neon builds.
  >
  > https://build.neon.kde.org/job/bionic_unstable_extras_labplot/188/
  >
  > 00:40:09 /workspace/build/src/backend/worksheet/plots/cartesian/XYCurve.cpp: In static member function ‘static int XYCurve::calculateMaxSteps(unsigned int)’:
  >  00:40:09 /workspace/build/src/backend/worksheet/plots/cartesian/XYCurve.cpp:1708:2: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]
  >  00:40:09   };
  >  00:40:09   ^
  
  
  Does it solve to explicitly set: "const char LogTable256[256]" to "const signed char LogTable256[256]" ?

REVISION DETAIL
  https://phabricator.kde.org/D18294

To: Murmele, asemke
Cc: rikmills, yurchor, kde-edu, Murmele, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190120/54022fbb/attachment-0001.html>