<table><tr><td style="">Murmele added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18294">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D18294#396744" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D18294#396744</a>, <a href="https://phabricator.kde.org/p/rikmills/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@rikmills</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Causes build failures on KDE Neon builds.</p>

<p><a href="https://build.neon.kde.org/job/bionic_unstable_extras_labplot/188/" class="remarkup-link" target="_blank" rel="noreferrer">https://build.neon.kde.org/job/bionic_unstable_extras_labplot/188/</a></p>

<p>00:40:09 /workspace/build/src/backend/worksheet/plots/cartesian/XYCurve.cpp: In static member function ‘static int XYCurve::calculateMaxSteps(unsigned int)’:<br />
 00:40:09 /workspace/build/src/backend/worksheet/plots/cartesian/XYCurve.cpp:1708:2: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]<br />
 00:40:09   };<br />
 00:40:09   ^</p></div>
</blockquote>

<p>Does it solve to explicitly set: "const char LogTable256[256]" to "const signed char LogTable256[256]" ?</p></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18294">https://phabricator.kde.org/D18294</a></div></div><br /><div><strong>To: </strong>Murmele, asemke<br /><strong>Cc: </strong>rikmills, yurchor, kde-edu, Murmele, narvaez, apol<br /></div>