D18304: Use the default RGB Colors for the XYZ Axis

[Tomaz Canabrava]

tcanabrava added a comment.


  karina, I belive the patch is good, I'll just wait for Aleix Pol answer, The two nitpicks that I posted are quite minor so I'll not block the review for those. we can fix those later.

INLINE COMMENTS

> plotitem.cpp:1
> +
>  /*************************************************************************************

stray empty line.

> plotter3d_es.cpp:47
>  
> -const GLubyte Plotter3DES::XAxisArrowColor[] = {250 -1 , 1, 1};
> +const GLubyte Plotter3DES::XAxisArrowColor[] = {250 -1, 1, 1};
>  const GLubyte Plotter3DES::YAxisArrowColor[] = {1, 255 - 1, 1};

stray empty space

REPOSITORY
  R323 Analitza

REVISION DETAIL
  https://phabricator.kde.org/D18304

To: karinapassos, #kde_edu, apol, tcanabrava
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190117/dbd33833/attachment.html>