<table><tr><td style="">tcanabrava added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18304">View Revision</a></tr></table><br /><div><div><p>karina, I belive the patch is good, I'll just wait for Aleix Pol answer, The two nitpicks that I posted are quite minor so I'll not block the review for those. we can fix those later.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18304#inline-101273">View Inline</a><span style="color: #4b4d51; font-weight: bold;">plotitem.cpp:1</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d">/*************************************************************************************</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">stray empty line.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18304#inline-101274">View Inline</a><span style="color: #4b4d51; font-weight: bold;">plotter3d_es.cpp:47</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #aa4000">const</span> <span class="n">GLubyte</span> <span class="n">Plotter3DES</span><span style="color: #aa2211">::</span><span class="n">XAxisArrowColor</span><span class="p">[]</span> <span style="color: #aa2211">=</span> <span class="p">{</span><span style="color: #601200">250</span> <span style="color: #aa2211">-</span><span style="color: #601200">1<span class="bright"></span></span><span class="bright"> </span><span class="p">,</span> <span style="color: #601200">1</span><span class="p">,</span> <span style="color: #601200">1</span><span class="p">};</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">const</span> <span class="n">GLubyte</span> <span class="n">Plotter3DES</span><span style="color: #aa2211">::</span><span class="n">XAxisArrowColor</span><span class="p">[]</span> <span style="color: #aa2211">=</span> <span class="p">{</span><span style="color: #601200">250</span> <span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">,</span> <span style="color: #601200">1</span><span class="p">,</span> <span style="color: #601200">1</span><span class="p">};</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #aa4000">const</span> <span class="n">GLubyte</span> <span class="n">Plotter3DES</span><span style="color: #aa2211">::</span><span class="n">YAxisArrowColor</span><span class="p">[]</span> <span style="color: #aa2211">=</span> <span class="p">{</span><span style="color: #601200">1</span><span class="p">,</span> <span style="color: #601200">255</span> <span style="color: #aa2211">-</span> <span style="color: #601200">1</span><span class="p">,</span> <span style="color: #601200">1</span><span class="p">};</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">stray empty space</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R323 Analitza</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18304">https://phabricator.kde.org/D18304</a></div></div><br /><div><strong>To: </strong>karinapassos, KDE Edu, apol, tcanabrava<br /><strong>Cc: </strong>kde-edu, narvaez, apol<br /></div>