D17945: Tutorial screen added for odd even activity
Aman Kumar Gupta
noreply at phabricator.kde.org
Mon Jan 14 15:16:51 GMT 2019
amankumargupta added inline comments.
INLINE COMMENTS
> Tutorial2.qml:1
> +/* GCompris - Tutorial2.qml
> + *
I haven't tested the patch but I think you can refactor the files Tutorial1.qml and Tutorial2.qml.
> Tutorial5.qml:30
> +
> +}
I think Tutorial3.qml, Tutorial4.qml, Tutorial5.qml can be refactored and prevent creating separate files.
> TutorialBase.qml:75
> + GCText {
> + id: oddNumber
> + anchors {
evenNumber and oddNumber can be refactored.
> TutorialBase.qml:114
> + GCText {
> + id: wrongMessage
> + anchors {
rightMessage and wrongMessage can be refactored
REPOSITORY
R2 GCompris
REVISION DETAIL
https://phabricator.kde.org/D17945
To: dekumar, #gcompris_improvements, jjazeix
Cc: amankumargupta, jjazeix, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190114/dda9656e/attachment.html>
More information about the kde-edu
mailing list