D17945: Tutorial screen added for odd even activity

[Johnny Jazeix]

jjazeix added inline comments.

INLINE COMMENTS

> Cloud.qml:26
>  
> +
>  Image {

why this change?

> Cloud.qml:41
>      fillMode: Image.PreserveAspectFit
> -
> +    visible: !(Activity.items.tutorialImage.visible)
>      z: 5

you shouldn't change the visibility of the clouds.
They should be started to be created only once the tutorial is finished (or at start if there is no tutorial for the activity)

> Planegame.qml:32
>  
> -    onStart: { focus = true; }
> +    onStart: { focus = true;}
>      onStop: { }

why this change?

> Planegame.qml:63
>  
> -        Component.onCompleted: {
> -            activity.start.connect(start)
> -            activity.stop.connect(stop)
> +        Component.onCompleted:{
> +                activity.start.connect(start)

why this change?

> Planegame.qml:87
> +        // Tutorial section starts
> +         Image {
> +         id: tutorialImage

indentation

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D17945

To: dekumar, #gcompris_improvements, jjazeix
Cc: amankumargupta, jjazeix, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20190114/bc8aaf57/attachment-0001.html>