D15841: Massive octave session and expression refactoring
Nikita Sirgienko
noreply at phabricator.kde.org
Sat Sep 29 22:35:08 BST 2018
sirgienko created this revision.
sirgienko added reviewers: asemke, filipesaraiva.
sirgienko added a project: Cantor.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
sirgienko requested review of this revision.
REVISION SUMMARY
Massive refactoring OctaveSession and OctaveExpression, for fixing some bugs and problems:
- fix bug with unhandling error in Expression with plog commands
- remove finalazing in OctaveExpression: handle output in parseOutput function and error in parseError
- fix problem, when octave prompt comes BEFORE error message, and we ignore error or some internal command handle it.
- simplify logic in OctaveSession::readOutput
- add handling subprompt (octave print subprompt, when user write unfinished octave statement)
TEST PLAN
1. Test with all Octave cws
2. If there are errors, comment them to this phabricator thread
REPOSITORY
R55 Cantor
BRANCH
octave-massive-refactoring
REVISION DETAIL
https://phabricator.kde.org/D15841
AFFECTED FILES
src/backends/octave/octaveexpression.cpp
src/backends/octave/octaveexpression.h
src/backends/octave/octavesession.cpp
src/backends/octave/octavesession.h
To: sirgienko, asemke, filipesaraiva
Cc: kde-edu, filipesaraiva, asemke, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180929/19191334/attachment.html>
More information about the kde-edu
mailing list