D15581: altered references to 0 in null pointers

Tomaz Canabrava noreply at phabricator.kde.org
Mon Sep 17 21:46:42 BST 2018

tcanabrava added a comment.

  You added a wrong file to the commit, please remove the CMaleLists.txt.user, also try to reason with the change: some elements that you changed the 0 to nullptr makes sense but others should be refactored to not use pointers.
  I know this is out of the scope of this patch, so I'll accept as soon as you remove the CMALELISTS.txt.user


> kalziumutils.cpp:131
> +        //val = el->dataAsVariant(kind).toInt();
> +        int v_int = el->dataAsVariant(kind).toInt();
>          if (val > 1600) {

Why thIs change? Also don't commit commented code.

  R326 Kalzium


To: carlos_hdc, tcanabrava
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180917/eb7d7c70/attachment.html>

More information about the kde-edu mailing list