<table><tr><td style="">tcanabrava added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15581">View Revision</a></tr></table><br /><div><div><p>You added a wrong file to the commit, please remove the CMaleLists.txt.user, also try to reason with the change: some elements that you changed the 0 to nullptr makes sense but others should be refactored to not use pointers.</p>

<p>I know this is out of the scope of this patch, so I'll accept as soon as you remove the CMALELISTS.txt.user</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15581#inline-83993">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kalziumutils.cpp:131</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">val</span> <span style="color: #aa2211">=</span> <span class="n">el</span><span style="color: #aa2211">-></span><span class="n">dataAsVariant</span><span class="p">(</span><span class="n">kind</span><span class="p">).</span><span class="n">toInt</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="bright"></span><span style="color: #74777d"><span class="bright">//</span>val = el->dataAsVariant(kind).toInt();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">int</span> <span class="n">v_int</span> <span style="color: #aa2211">=</span> <span class="n">el</span><span style="color: #aa2211">-></span><span class="n">dataAsVariant</span><span class="p">(</span><span class="n">kind</span><span class="p">).</span><span class="n">toInt</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">val</span> <span style="color: #aa2211">></span> <span style="color: #601200">1600</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why thIs change? Also don't commit commented code.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R326 Kalzium</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D15581">https://phabricator.kde.org/D15581</a></div></div><br /><div><strong>To: </strong>carlos_hdc, tcanabrava<br /><strong>Cc: </strong>kde-edu, narvaez, apol<br /></div>