D15546: Fix Scheduler slewing stage andwq dome interaction.

[Eric Dejouhanet]

TallFurryMan created this revision.
TallFurryMan added reviewers: mutlaqja, wreissenberger.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
TallFurryMan requested review of this revision.

REVISION SUMMARY
  Fixed dome isMoving property, which was declared as method.
  Moved dome movement check to checkJobStage to avoid a lock-up in the case the dome has not finished moving when the mount has.
  That lock-up would happen because the dome check was done upon notification of the end of the slew, and that no further notification would come to test the dome again.
  Moving that code block also avoids duplicating it for stages "STAGE_SLEWING" and "STAGE_RESLEWING".
  Admittedly, when there is no dome in the setup, the next action could be taken directly in the mount callback, but the cost of deferring this to checkJobStage is light.
  Moreover the use of the intermediate stages "STAGE_SLEW_COMPLETE" and "STAGE_RESLEWING_COMPLETE" clarifies the code of the state machine.

TEST PLAN
  Use test vector "simple_test_no_twilight".
  Without the change, Scheduler starts slewing to the first target and hangs there doing nothing.
  With the change, Scheduler completes the first target successfully.
  However, observe as Scheduler subsequently selects the same target and hangs there - next issue to tackle!

REPOSITORY
  R321 KStars

BRANCH
  bugfix__dbus_slew_completion (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15546

AFFECTED FILES
  kstars/ekos/auxiliary/dome.h
  kstars/ekos/scheduler/scheduler.cpp
  kstars/org.kde.kstars.Ekos.Dome.xml

To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20180916/42909c9a/attachment-0001.html>